PR template when adding a new library #913
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wauplin
requested review from
Vaibhavs10,
julien-c,
osanseviero and
pcuenca
Vaibhavs10
approved these changes
Sep 19, 2024
|
I've addressed feedback in b54ffcc. I have added |
|
Well, I've been enthusiastic a bit too quickly... This feature requires the user to manually edit their URL to make it work >< . I'll try to hack something based on https://stackoverflow.com/questions/73771068/multiple-templates-for-pull-requests-on-github |
Wauplin
added a commit
that referenced
this pull request
Oct 9, 2024
Reverting #913 now that huggingface/hub-docs#1442 has been merged. The PR template was not discoverable at all. Now users should be redirected to https://huggingface.co/docs/hub/models-adding-libraries which contains the same information.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a template with a checklist to follow when adding a new library.
Based on https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/creating-a-pull-request-template-for-your-repository.
Once merged, we should be able to generate a link to create such a PR (the template will not be used by default for all PRs 😄). This link would be added to https://huggingface.co/docs/hub/models-download-stats#can-i-add-my-query-files-for-my-library.
Hopefully, this should reduce the back-and-fourth when someone adds a new library. I suggest we start with that as an experiment and if it doesn't work, we can move it somewhere else as documentation.